fix: Updates error message in csv parser to recommend schema_overrides instead of deprecated dtypes argument #19416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvillaveces
requested review from
ritchie46,
orlp and
c-peters
as code owners
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19416 +/- ##
==========================================
+ Coverage 80.03% 80.04% +0.01%
==========================================
Files 1532 1532
Lines 210749 210749
Branches 2442 2442
==========================================
+ Hits 168676 168699 +23
+ Misses 41518 41495 -23
Partials 555 555 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small PR. I found it a little annoying that the error message recommends using an argument that has been deprecated and gives a warning, instead of recommending the updated argument. So I decided to try and fix it 😄